search

iitc-project / ingress-intel-total-conversion

ingress.com/intel total conversion user script with some new features. Should allow easier extension of the intel map.
http://iitc.jonatkins.com/
ISC License
991 stars 552 forks source link

new plugin : Portal list #9

Closed teo96 closed 11 years ago

teo96 commented 11 years ago

I created an IITC plugin that display all loaded portals in a table with filter/sort options See it in action : https://github.com/teo96/iitc-plugins/raw/master/portals-list.user.js Screenshot : https://plus.google.com/113965246471577467739/posts/1TapQN6usoW

Maybe you want to add it in the plugins list ?

(I know i can fork, add my plugin, make a pull request ... but i have no git environnement and never used it, just github ...)

jonatkins commented 11 years ago

OK, I'll accept this.

I've now pushed it into my Github repositry. Please, look at making a fork and setting up git locally - it's not that tricky and there's good tutorials here on Github itself.

Any future updates would be so much easier that way.

One thing - the sort code currently duplicates an (almost) identical block of code for ascending/descending sort. It'd be better if it had the block of code once, then followed by 

  if ( sortorder > 0 )
    retval = -retval;
teo96 commented 11 years ago

Ok, thanks, you give me a good motivation to dive into the git wonderful world :) And thanks again for the sort advice, that's my first .js work and sorting is not the easier part