iitpkd / templates

Repository containing templates for various documents at iitpkd
BSD 3-Clause "New" or "Revised" License
4 stars 2 forks source link

A new test template #2

Open albert-sunny opened 6 years ago

albert-sunny commented 6 years ago

I have removed the log files

piyush-kurur commented 6 years ago

Can you squash all the Makefile changes (f33e1f4, a47ec74, f1e8598) into one commit. Also the previous three commits into one.

You can do a rebase -i and then use squash/fixup.

albert-sunny commented 6 years ago

I have done it. Do i have to close the pull request and issue a new one?

piyush-kurur commented 6 years ago

No as I said you do not have to close it. If you push more commits to this branch, it will get added. That is the typical workflow.

  1. You send pull request
  2. Reviewer sends comments
  3. You add more commits and/or rebases and cleanup
  4. (2) (3) happens many times and finally the reviewer accepts or rejects the pull request.
albert-sunny commented 6 years ago

Ok. Thanks for the clarification :)