Db proxy chart - Githubissues

iits-consulting / charts

Common helm charts we use

GNU General Public License v3.0

14 stars 7 forks source link

Db proxy chart #73

Closed ezemegwara closed 11 months ago

victorgetz commented 11 months ago

Review:

Please add .trivyignore file we will enable trivy again soon
i would use {{ .Release.Name }} and not {{ .Chart.Name }}
The Range over the services is not working it would output such thing:

          ports:
          - containerPort: 5330
          args:
            - tcp-listen:5330,fork,reuseaddr
            - tcp-connect:REPLACE ME WITH DB NAME:5432
          - containerPort: 5330
          args:
            - tcp-listen:5330,fork,reuseaddr
            - tcp-connect:REPLACE ME WITH DB NAME:5432

ezemegwara commented 11 months ago

corrections are done

victorgetz commented 11 months ago

Did some changes will merge now