Service Accounts - Githubissues

iits-consulting / otc-auth

Open Source CLI for the Open Telekom Cloud written in go.

GNU General Public License v3.0

44 stars 5 forks source link

Service Accounts #9

Closed zeljkobekcic closed 1 year ago

zeljkobekcic commented 1 year ago

This code is able to authenticate against the OTC with a correctly configured keycloak and IAM provider.

This is not finished and required more work to be well integrated.

This PR resolves https://github.com/iits-consulting/otc-auth/issues/6

victorgetz commented 1 year ago

@zeljkobekcic is it ready for review?

zeljkobekcic commented 1 year ago

Yes, please review it. There are also some merge conflicts after the recent refactoring. I will take care of it soon. The general logic is not affected.

victorgetz commented 1 year ago

rebase on master is needed
i would add also documentation i don't know atm how to use it
--service-account flag is on the wrong position you implement it for oidc only so it should be available only for " idp-oidc" because for iam it will not work

i would recommend to make this code more tidy, capsulate the things more:

https://github.com/iits-consulting/otc-auth/blob/d14880c70f0aba14dd7caa8d0f61d4ea5b5f6bc7/src/oidc/server.go#L104-L128

zeljkobekcic commented 1 year ago

✅ We can now merge the PR (merged the master into this branch) ✅ Moved the service account flag to the correct position ✅ Cleaned up the code a little bit more ✅ Docs