iits-consulting / terraform-opentelekomcloud-project-factory

This repository helps to create an OTC-based cloud-native infrastructure landscape with Kubernetes, load balancers, VPCs, etc. With these modules, we provide you a rocket start while you can still deep-dive into detailed configuration later.
GNU General Public License v3.0
84 stars 20 forks source link

adding node pool ssh keys to output #69

Closed k11h-de closed 1 year ago

k11h-de commented 1 year ago

Hi iits,

In order to do troubleshooting, it is required to login into the node pools nodes sometimes. This PR is adding the pub and private ssh keys to the output.

victorgetz commented 1 year ago

Hi sorry we had a big project and all of our CloudOps Consultants had no time for the ProjectFactory. We will take a look today

k11h-de commented 1 year ago

Hi @victorgetz Do you think it makes sense to merge this PR? I would love to see these terraform exports.

Thanks and all the best Karsten

canaykin commented 1 year ago

Hi Karsten,

I will approve the merge request but please note that the default ssh keys were removed from the jumphost module and I intend to do the same for the CCE nodes as soon as it becomes a possibility within the OTC provider.

That being said, I would still recommend using the post_install variable to inject personalized public keys via a script and not sharing private key(s) across multiple admins. This way it will also stay compatible when we choose to remove the default key approach.

Alternatively, I can also recommend using kubectl debug node/<node-name> -it --image=<image name> to use a more kubernetes native way to check hosts. This of course is only possible if the node can run a pod so it will not apply to situations where the kubelet is down.

Best, Can.