iiumschedule / iium_schedule

Make/Generate IIUM timetable with ease. Integration with IIUM database. App available on Android, MacOS & Windows.
https://iiumschedule.iqfareez.com
MIT License
25 stars 9 forks source link

💡 User's schedule data is not updated whenever data from i-Maluum is updated #50

Closed ElyasAsmad closed 1 year ago

ElyasAsmad commented 2 years ago

Description

Whenever new data from i-Maluum emerges, user need to remove all the relative subjects and re-add it again to see the changes.

Steps to Reproduce

  1. Create a new schedule by adding subjects or courses.
  2. (At this particular time, there are some unassigned lecturers / lecture rooms for some courses).
  3. Changes from i-Maluum didn't reflect on the current version of the app.
  4. Users need to remove all subjects and re-add it again to see new data emerges.

More Information

Device: OnePlus 9 (LE2115) OS: OxygenOS 12 (Android 12) App Version: 1.0.3

Reported by @haikalakif

Attachments

IMG_20221027_094741.jpg IMG_20221027_094759.jpg

ElyasAsmad commented 2 years ago

⚠️ New bug emerges as improper hardcoded index value and unsafe null check (!) is being used.

New PR will be submitted afterwards.

ElyasAsmad commented 2 years ago

Bug Fixes

Refer Commit d440b1d