ije / md4w

A Markdown renderer written in Zig & C, compiled to WebAssymbly.
MIT License
58 stars 0 forks source link

Monorepo structure #12

Closed karesztrk closed 1 month ago

karesztrk commented 1 month ago

On my side the Zig build is failing with the following:

/home/ktorok/Projects/md4w/packages/core/build.zig:12:33: error: no field named 'path' in union 'Build.LazyPath'
        .root_source_file = .{ .path = "src/md4w.zig" },
                                ^~~~
/usr/lib/zig/std/Build.zig:2171:22: note: union declared here
pub const LazyPath = union(enum) {
                     ^~~~~
referenced by:
    build: /home/ktorok/Projects/md4w/packages/core/build.zig:4:14
    runBuild__anon_8819: /usr/lib/zig/std/Build.zig:2116:27
    remaining reference traces hidden; use '-freference-trace' to see all reference traces
/home/ktorok/Projects/md4w/packages/core/build.zig:12:33: error: no field named 'path' in union 'Build.LazyPath'
        .root_source_file = .{ .path = "src/md4w.zig" },
                                ^~~~
/usr/lib/zig/std/Build.zig:2171:22: note: union declared here
pub const LazyPath = union(enum) {
                     ^~~~~
karesztrk commented 1 month ago

You may want to extend the README, @ije

ije commented 1 month ago

On my side the Zig build is failing with the following:

please use zig 0.11, the wasm build output of zig 0.12+ is significantly increased. i still wonder what change happened, and i have a plan to rewrite it in pure zig.

karesztrk commented 1 month ago

I see. If you have any other improvement ideas then let me know. By the way, I wished to name the webcomponent part like md4w/webcomponent but that's an invalid name. That would require a scope package. Do you have plans towards scoped packages?

karesztrk commented 1 month ago

@ije are you still considering the merge of our works into a monorepo? If not then we can close this.

ije commented 1 month ago

sorry for the late reply and thanks for your contribution, i feel this PR beyonds the simple goal of being a wasm module wihtout deps. why not keep the md4wc in your scope and put the link in this repo?

karesztrk commented 1 month ago

Sure, no problem