search

ijgnd / anki__extended_tag_edit_add_dialog

2 stars 2 forks source link

Added ability to browser search a selected tag #7

Closed ryerrabelli closed 3 years ago

ijgnd commented 3 years ago

Thanks for the addition.

I'm not a lawyer so I'm extra careful: Could you answer and state that you release your code under the GPLv3+/AGPLv3+.

I'll make some small tweaks to your code so I plan to remove your comment lines "### Rahul Yerrabelli code start/end" and instead add your name to the top and mention your commit id?

ryerrabelli commented 3 years ago

Hi,

Yes, I realize my code under the same license you gave. Feel free to make any and all changes. I originally wrote my name around the part so I'd know which parts I changed in case anything broke. It seems like everything works fine though so please feel free to remove and add my name to the top like you mentioned. Thanks for the great add on. I use it a lot!

Sincerely, Rahul Yerrabelli

On Mon, Mar 15, 2021 at 4:34 PM ijgnd @.***> wrote:

Thanks for the addition.

I'm not a lawyer so I'm extra careful: Could you answer and state that you release your code under the GPLv3+/AGPLv3+.

I'll make some small tweaks to your code so I plan to remove your comment lines "### Rahul Yerrabelli code start/end" and instead add your name to the top and mention your commit id?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ijgnd/anki__extended_tag_edit_add_dialog/pull/7#issuecomment-799767716, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB5IPOQV23Q7KCN6QG4A62TTDZ4MVANCNFSM4YTVCVWA .

ijgnd commented 3 years ago

I just added a bunch of small changes including a shortcut for the new search button.

Would you mind testing the latest version of __init__.py? For the search shortcut you also need to add "in tag lines dialog: search browser for tag": "Ctrl+s", to your config.

Thank you very much.