search

ijingshan / gwt-charts

Automatically exported from code.google.com/p/gwt-charts
0 stars 0 forks source link

ControlWrapperWidget - StateChangedHandler #15

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 

Hello again,

How's it going with the project?

1. In the addStateChangedHandler of the ControlWrapperObject you have something 
like this:

return addListener(StateChangedEvent.NAME, handler); 

where public static String NAME = "statechanged"; Actually the name is 
"statechange" as I tested on the playground from google. I may be wrong but i 
tested with "statechanged" and it did not throw the event, while with 
"statechange" i did.

2. Also in the HasListeners class there is a method
removeListener(HandlerRef handlerRef) in which you have something like 
removeListener(handlerReg); You can see that the parameters don't match because 
of the last letter.

Thank you for your hard work. Keep it going with the great job!
Ovi

Original issue reported on code.google.com by ovidiu.f...@gebs.ro on 15 Oct 2012 at 2:21

GoogleCodeExporter commented 9 years ago 
You're absolutely right.
I'm going to fix it and make a new release today.

Original comment by rglafo...@gmail.com on 15 Oct 2012 at 2:41

GoogleCodeExporter commented 9 years ago

Original comment by rglafo...@gmail.com on 15 Oct 2012 at 3:17

GoogleCodeExporter commented 9 years ago

Original comment by rglafo...@gmail.com on 7 Dec 2012 at 12:06