search

ijingshan / gwt-charts

Automatically exported from code.google.com/p/gwt-charts
0 stars 0 forks source link

DashboardWidget.bind() clears preset containerIDs #24

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
The bind method below  preset the container ids of the control and 
chartwrappers, without checking if the widgets have already set needed Id.

    public final void bind(ControlWrapperWidget<?> controlWrapper, ChartWrapperWidget<?> chartWrapper) {
        controlWrapper.setContainerId(DOM.createUniqueId());
        chartWrapper.setContainerId(DOM.createUniqueId());
        dashboardObject.bind(controlWrapper.getObject(), chartWrapper.getObject());
    }

Original issue reported on code.google.com by dimiter....@gmail.com on 17 Nov 2012 at 9:25

GoogleCodeExporter commented 9 years ago

Original comment by rglafo...@gmail.com on 17 Nov 2012 at 10:46

GoogleCodeExporter commented 9 years ago 
This was a bad implementation.
Instead, the control and chart wrappers will assign a container id on creation.
You can decide to change it or not.
But you should not need to do it unless you're using HTML.
Check out the example in the Showcase which is pure GWT.

Original comment by rglafo...@gmail.com on 18 Nov 2012 at 12:25

GoogleCodeExporter commented 9 years ago

Original comment by rglafo...@gmail.com on 7 Dec 2012 at 12:06