search

ijlyttle / bsplus

Shiny and R Markdown addons to Bootstrap 3
http://ijlyttle.github.io/bsplus/
Other
146 stars 23 forks source link

bs_modal example simplification? #24

Closed jpmarindiaz closed 7 years ago

jpmarindiaz commented 7 years ago

FROM

bs_modal(
  id = "modal_markdown", 
  title = "Using Markdown",
  body = render_html_fragment(
    system.file("markdown", "modal.md", package = "bsplus"),
    quiet = TRUE
  )
)

TO

bs_modal(
  id = "modal_markdown", 
  title = "Using Markdown",
  body = includeMarkdown(system.file("markdown", "modal.md", package = "bsplus"))
)
ijlyttle commented 7 years ago

I had forgotten that shiny::includeMarkdown() exists.

I have been "wrestling" with render_html_fragment() for a while - maybe it will be easiest to get rid of it.

Thanks!

ijlyttle commented 7 years ago

render_html_fragment() removed in ddb4743