Closed schloerke closed 4 years ago
The shiny team has found an error while doing a reverse dependency check.
shiny
> test_check("bsplus") ── 1. Failure: constructor with different column-specs (@test-accordion_sidebar. tagGetAttribute(acc_sidebar_side, "class") not identical to "col-sm-3 col-sm-offset-1". 1/1 mismatches x[1]: "col-sm-3 offset-md-1 col-sm-offset-1" y[1]: "col-sm-3 col-sm-offset-1" ── 2. Failure: constructor with different column-specs (@test-accordion_sidebar. tagGetAttribute(acc_sidebar_main, "class") not identical to "col-sm-7 col-sm-offset-1". 1/1 mismatches x[1]: "col-sm-7 offset-md-1 col-sm-offset-1" y[1]: "col-sm-7 col-sm-offset-1" ══ testthat results ═══════════════════════════════════════════════════════════ [ OK: 102 | SKIPPED: 0 | WARNINGS: 0 | FAILED: 2 ] 1. Failure: constructor with different column-specs (@test-accordion_sidebar.R#57) 2. Failure: constructor with different column-specs (@test-accordion_sidebar.R#59)
I believe this change still keeps the intent while allowing shiny / markdown / htmltools some flexibility in the code.
markdown
htmltools
We are aiming to release the week of May 25th. We hope this does not disrupt your package on CRAN.
Thank you! - Barret
Hi Barret,
Thanks!
I am pleased (but not surprised) to see that the PR is backwards-compatible.
Will aim for a CRAN release of my own soon!
The
shiny
team has found an error while doing a reverse dependency check.I believe this change still keeps the intent while allowing
shiny
/markdown
/htmltools
some flexibility in the code.We are aiming to release the week of May 25th. We hope this does not disrupt your package on CRAN.
Thank you! - Barret