ijlyttle / bsplus

Shiny and R Markdown addons to Bootstrap 3
http://ijlyttle.github.io/bsplus/
Other
147 stars 23 forks source link

Use expect_match vs expect_identical #74

Closed schloerke closed 4 years ago

schloerke commented 4 years ago

The shiny team has found an error while doing a reverse dependency check.

> test_check("bsplus")
── 1. Failure: constructor with different column-specs (@test-accordion_sidebar.
tagGetAttribute(acc_sidebar_side, "class") not identical to "col-sm-3 col-sm-offset-1".
1/1 mismatches
x[1]: "col-sm-3 offset-md-1 col-sm-offset-1"
y[1]: "col-sm-3 col-sm-offset-1"

── 2. Failure: constructor with different column-specs (@test-accordion_sidebar.
tagGetAttribute(acc_sidebar_main, "class") not identical to "col-sm-7 col-sm-offset-1".
1/1 mismatches
x[1]: "col-sm-7 offset-md-1 col-sm-offset-1"
y[1]: "col-sm-7 col-sm-offset-1"

══ testthat results  ═══════════════════════════════════════════════════════════
[ OK: 102 | SKIPPED: 0 | WARNINGS: 0 | FAILED: 2 ]
1. Failure: constructor with different column-specs (@test-accordion_sidebar.R#57) 
2. Failure: constructor with different column-specs (@test-accordion_sidebar.R#59) 

I believe this change still keeps the intent while allowing shiny / markdown / htmltools some flexibility in the code.


We are aiming to release the week of May 25th. We hope this does not disrupt your package on CRAN.

Thank you! - Barret

ijlyttle commented 4 years ago

Hi Barret,

Thanks!

I am pleased (but not surprised) to see that the PR is backwards-compatible.

Will aim for a CRAN release of my own soon!