ijmarshall / robotreviewer

Automatic synthesis of RCTs
https://www.robotreviewer.net
GNU General Public License v3.0
140 stars 83 forks source link

Removes InferenceRobot from PDF Annotations workflow #44

Closed sgalvezortiz closed 3 years ago

sgalvezortiz commented 3 years ago

Problem

When running the PDF Annotation pipeline locally, it was identified that the InferenceRobot was performing requests to a remote service at http://trialstreamer.ccs.neu.edu:8000 which did not correspond to any local process being run on RobotReviewer. This was communicated to @bwallace, who mentioned that this robot was experimental and should be removed from the pipeline.

Solution

Since the InferenceRobot was being run separately from the rest of the robots at the pdf_annotation_pipeline function in the ml_worker, it is enough to remove the try/catch block calling the execution along with the global instance inf_bot at the worker init function.

The codebase of the InferenceRobot will still be available at robotreviewer/robots/inference_robot.py, but will no longer be instantiated or used.