search

ijpatricio / mingle

Use JS components with Vue or React in a Laravel Livewire and/or Filament application
MIT License
205 stars 6 forks source link

Ensure stub matches the same signature as the trait #5

Closed andruu closed 1 month ago

ijpatricio commented 2 months ago

Hello. Thank. I will merge it, and also have to change something further, that's why I didn't still merge. But I will. Thank you for this!

ijpatricio commented 1 month ago

Hello @andruu

So, how's it going?

Did you actually use Mingle in a project?

I'm having 2nd thoughts about the API, because when you receive a Collection, you don't need to collect again. You just mutate the collection, by $data->put('some-key' => $value). So I'll be now making a few experiments.

This was a good catch, thank you!