Closed imagejan closed 2 years ago
Hi @imagejan! It seems I merged this too fast and now the building is failing. The errors come from the javadoc generation, so I believe they were skipped before?
@imagejan I have invited @hinerm and @ctrueden as "owners" (I hope you don't mind, @dlegland).
Shall I change the pre-release to use the semantic versioning?
Hi, I think that's ok for the time to solve the problem.
More generally, I appreciate the efforts made to make all the ImageJ/Fiji contributions working together; however, as it seems there are some rules or practices concerning the deployment of Fiji-related contributions, this would be convenient to have them summarized somewhere. If they are, maybe have a link in the PR message?
@iarganda wrote:
I have invited @hinerm and @ctrueden as "owners"
I have now added the needed secrets to the ijpb repository. Any public repositories in this organization will now be able to deploy to maven.scijava.org via GitHub Actions CI.
@iarganda wrote:
The errors come from the javadoc generation, so I believe they were skipped before?
I pushed a commit that fixes the doclint errors: d292f5284b06358d9a80df212226f22470242a75
@dlegland wrote:
it seems there are some rules or practices concerning the deployment of Fiji-related contributions, this would be convenient to have them summarized somewhere.
For MorphoLibJ, there are no rules, because it has its own update site. However, there are guidelines, which if you follow, the update site will stay in better sync with Fiji as it evolves.
About release best practices:
About contributing a plugin to the Fiji distribution (in case MorphoLibJ ever wants to be included in Fiji):
I also plan to write a document about becoming part of the pom-scijava Bill of Materials, which benefits MorphoLibJ in that it would get it tested in the big "melting pot" of SciJava-based components, to catch library version incompatibilities sooner. But I haven't written that document yet, unfortunately. I already added MorphoLibJ a while back, though, so there's no action needed from you there. :smile:
@ctrueden : that's great! thanks for fixing this! well, mea culpa, it seems I did not write comments the right way.... with the new systems I should be warned next time!
In order to have jar files for every release version of MorphoLibJ deployed to https://maven.scijava.org (and therefore available to third-party projects depending on it), please:
ijpb
organization, so they can add the SciJava secrets for deployment (if it didn't happen already),release-version.sh
to cut a new release (i.e. no more double-push to master, and in general never manually push a release version), andmajor.minor.patch