search

ijpiantanida / talkback

A simple HTTP proxy that records and playbacks requests
MIT License
284 stars 41 forks source link

Move buffer-shims to dependencies? #2

Closed vyorkin closed 6 years ago

vyorkin commented 6 years ago

I guess it should be in dependencies, coz its in the resulting bundle (dist/index.js). Am I right or I missed smth?

vyorkin commented 6 years ago

The problem is that I'm trying to use it with jest and got this error:

  ● Test suite failed to run

    Cannot find module 'buffer-shims' from 'index.js'

      at Resolver.resolveModule (../../node_modules/jest-resolve/build/index.js:191:17)
      at Object.<anonymous> (../../node_modules/talkback/index.js:47:18)
ijpiantanida commented 6 years ago

You're right! I just released a fix. Try it.

vyorkin commented 6 years ago

in the package.json:

"main": "index.js",

I think it should be dist/index.js, otherwise it is impossible to use it

ijpiantanida commented 6 years ago

I'm sorry, I was trying a new deployment script and ended up messing it up. Should be good to go now.

vyorkin commented 6 years ago

thank you! everything is ok now, I'll try to provide more feedback later