search

ijpiantanida / talkback

A simple HTTP proxy that records and playbacks requests
MIT License
284 stars 41 forks source link

Key order matters when comparing requests #32

Closed Vages closed 4 years ago

Vages commented 4 years ago

I've experienced problems with requests not being served when their key order changes. I have a PR coming up which fixes this; just wanted to make the issue to have something to tag it onto.

Vages commented 4 years ago

From the test "doesn't match pretty printed tapes with different body", it turns out that this behavior is intentional. I'll just write my own bodyMatcher instead. 😄

ijpiantanida commented 4 years ago

I think the test was more of a "let's document what's the current behavior" rather than an intentional decision.

I agree that it's better if key order doesn't matter for JSON requests.

I published 2.0.0 with this problem fixed. Thank you!

Vages commented 4 years ago

Thanks!