search

ijsto / strapi-provider-email-mailjet

Strapi Email service provider for Mailjet
MIT License
13 stars 11 forks source link

Default to name fix #5

Closed dannymatkovsky closed 3 years ago

dannymatkovsky commented 4 years ago

Fixes problem of potential mismatch of receiver's email address and name as described here. Also adds support of email only arrays (['email1@..., email2@...]) and enables throwing 'empty to' error only if both to and defaultTo are not set.

dannymatkovsky commented 3 years ago

@ScottAgirs fixed and tested.

But one more bug seems to be found. If you'll add Cc(as well Bcc and Attachments) field to your message, you'll get msg object of following structure:

{
  Messages: [
    {
      From: ...
      To: ...
      ...
    }
  ],
  Cc: ...,
  Bcc: ...
}
ScottAgirs commented 3 years ago

Hey @burlakko thanks for the commits and sorry for the delay, I think we're good to merge, the last thing, though - it looks like your ESLint/Prettier settings are reformatting things - please revert those changes, then merging in! :)

dannymatkovsky commented 3 years ago

Hi @ScottAgirs! Sorry for the delay. Can you please provide your eslint config file, so i could apply desired code formatting? Also maybe it's a good idea to have it inside of project?

ScottAgirs commented 3 years ago

@burlakko thanks for the PR, and you make a good point. I think the Linting issue is ok for now, we will be adding linting config to the project as you suggested! :)

Cheers!