ijyliu / ECMA-31330-Project

Econometrics and Machine Learning Group Project
2 stars 1 forks source link

Submission plan #100

Closed ijyliu closed 2 years ago

ijyliu commented 3 years ago

@marionoro should probably be the one to do the upload since he submitted the earlier stuff and we definitely don't want to send them stuff from multiple people

paul-opheim commented 3 years ago

Wouldn't it be better to just submit the Source folder, instead of submitting the entire repo?

I would imagine it might be confusing for them if we submitted the whole repo when they just asked for the code.

ijyliu commented 3 years ago

if you submit the whole thing the readme and data is included. but probably doesn't matter

paul-opheim commented 3 years ago

How about I change the name of the folder from "Source" to "Commented Code" so that it's clear for them?

ijyliu commented 3 years ago

Yeah, but don't do it to the repo copy cause that will break things

paul-opheim commented 3 years ago

Okay

ijyliu commented 3 years ago

I guess we just kind of wait for nico now

hah, lucky issue 100

paul-opheim commented 3 years ago

Are the terms used on Github standard? I've never heard of dividing folders into "Source", "Release", etc.

paul-opheim commented 3 years ago

Not a huge surprise, but the whole folder is taking a long time to upload to Canvas lol.

ijyliu commented 3 years ago

No but I wish more people used the same directory structure lol

culprit is probably the jupyter notebook

paul-opheim commented 3 years ago

Alright, I submitted it as it currently is.

paul-opheim commented 3 years ago

Nico has 30 minutes left in his final and then he'll be able to work on this.

paul-opheim commented 3 years ago

Do we have non-parallelized code that does exactly what our submitted parallel code does? Maybe it would be helpful to email that to Nadav in case he can't run the parallelized code for some reason.

Also, I'm not sure how we can let them know that reading the readme explains everything, since you don't seem to be able to attach a note to your submission of files.

ijyliu commented 3 years ago

I think you can leave a comment on canvas

ijyliu commented 3 years ago

I mean technically there's like no way they can run the code since it would take too long. But I'll dig through and find the latest non-parallel version. Then can copy-paste into that to make sure it's up to date

paul-opheim commented 3 years ago

I do not see how to do so.

ijyliu commented 3 years ago

image

you can definitely do it somehow. it might be after you submit

ijyliu commented 3 years ago

Click view feedback

ijyliu commented 3 years ago

So here's your old jupyternotebook from 2 days ago. Should be able to copy paste and make minor edits inside the loop.

https://github.com/ijyliu/ECMA-31330-Project/blob/ab31254d835b80da44cded58a27e302b1c8f217e/Source/Simulations/Run_Simulations.ipynb

I guess maybe test it on 1 sim. Do this outside the repo so that we don't overwrite any results

paul-opheim commented 3 years ago

Ah I see! I thought only the professor could leave a comment there.

ijyliu commented 3 years ago

@marionoro pdf now finalized

ijyliu commented 3 years ago

did the code thing work out ok

paul-opheim commented 3 years ago

Wait have you made changes since 8:41?

ijyliu commented 3 years ago

Yes but only to the pdf

On Sat, Jun 5, 2021 at 10:07 PM marionoro @.***> wrote:

Wait have you made changes since 8:41?

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/ijyliu/ECMA-31330-Project/issues/100#issuecomment-855324324, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQCGE4J3MGU7ZKXM2C35QBDTRLJ7FANCNFSM46FBERUA .

paul-opheim commented 3 years ago

Alright, I'll submit again.

ijyliu commented 3 years ago

Sorry for any prior miscommunication here. You have the (hopefully satisfying) honor of checking the last two boxes and closing this issue though.

paul-opheim commented 3 years ago

Thank you letting me have this honor lol.

Here we go. Thank y'all for working on this project together!

image