Closed ijyliu closed 2 years ago
Wouldn't it be better to just submit the Source folder, instead of submitting the entire repo?
I would imagine it might be confusing for them if we submitted the whole repo when they just asked for the code.
if you submit the whole thing the readme and data is included. but probably doesn't matter
How about I change the name of the folder from "Source" to "Commented Code" so that it's clear for them?
Yeah, but don't do it to the repo copy cause that will break things
Okay
I guess we just kind of wait for nico now
hah, lucky issue 100
Are the terms used on Github standard? I've never heard of dividing folders into "Source", "Release", etc.
Not a huge surprise, but the whole folder is taking a long time to upload to Canvas lol.
No but I wish more people used the same directory structure lol
culprit is probably the jupyter notebook
Alright, I submitted it as it currently is.
Nico has 30 minutes left in his final and then he'll be able to work on this.
Do we have non-parallelized code that does exactly what our submitted parallel code does? Maybe it would be helpful to email that to Nadav in case he can't run the parallelized code for some reason.
Also, I'm not sure how we can let them know that reading the readme explains everything, since you don't seem to be able to attach a note to your submission of files.
I think you can leave a comment on canvas
I mean technically there's like no way they can run the code since it would take too long. But I'll dig through and find the latest non-parallel version. Then can copy-paste into that to make sure it's up to date
I do not see how to do so.
you can definitely do it somehow. it might be after you submit
Click view feedback
So here's your old jupyternotebook from 2 days ago. Should be able to copy paste and make minor edits inside the loop.
I guess maybe test it on 1 sim. Do this outside the repo so that we don't overwrite any results
Ah I see! I thought only the professor could leave a comment there.
@marionoro pdf now finalized
did the code thing work out ok
Wait have you made changes since 8:41?
Yes but only to the pdf
On Sat, Jun 5, 2021 at 10:07 PM marionoro @.***> wrote:
Wait have you made changes since 8:41?
— You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/ijyliu/ECMA-31330-Project/issues/100#issuecomment-855324324, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQCGE4J3MGU7ZKXM2C35QBDTRLJ7FANCNFSM46FBERUA .
Alright, I'll submit again.
Sorry for any prior miscommunication here. You have the (hopefully satisfying) honor of checking the last two boxes and closing this issue though.
Thank you letting me have this honor lol.
Here we go. Thank y'all for working on this project together!
@marionoro should probably be the one to do the upload since he submitted the earlier stuff and we definitely don't want to send them stuff from multiple people