search

ijyliu / ECMA-31330-Project

Econometrics and Machine Learning Group Project
2 stars 1 forks source link

Paul looks over Isaac's Code (when he has cleaned it up) #84

Closed paul-opheim closed 3 years ago

paul-opheim commented 3 years ago

Files here: https://github.com/ijyliu/ECMA-31330-Project/tree/main/Source/Application

ijyliu commented 3 years ago

^ have at it!

paul-opheim commented 3 years ago

The code all looks good to me. Are you confident that this line of code is right now:

image

If so, we probably want to delete that comment on line 175 lol.

ijyliu commented 3 years ago

do you want to check it? you can go to that link or also look at the documentation and print the results

paul-opheim commented 3 years ago

I've looked through it and it makes sense to me. The results seem reasonable as well. I deleted the comment and I'll close out this issue.