ijyliu / ECMA-31330-Project

Econometrics and Machine Learning Group Project
2 stars 1 forks source link

switch to using sklearn's pca #91

Closed ijyliu closed 3 years ago

ijyliu commented 3 years ago

it seems to do better and we should do this for consistency

Do this in both

There should be an example in my parallel run sims code

ijyliu commented 3 years ago

Ugh for the empirical code this could be a pain because we were using the built-in functions for the scree plot, etc from that other pca package...

ijyliu commented 3 years ago

So it's probably not worth it