search

ik1xpv / ExtIO_sddc

ExtIO_sddc.dll - BreadBoard RF103 / HDSDR
Other
69 stars 26 forks source link

Split the current pipeline into stages #199

Closed howard0su closed 2 years ago

ik1xpv commented 3 years ago

Very cool! It's an impressive change! I checked CMake #203 vs CMake #198 justarun4 Other than the different CPU load that's expected in the development stage, I noticed a little increase of background level on the negative filtered out frequencies.

ik1xpv commented 3 years ago

The background level seems to increase in CMake #203 while CMake # 199,201,202 are equal to 198.

howard0su commented 3 years ago

what revision #203 is refering?

ik1xpv commented 3 years ago

I used the Actions compiled release dll
https://github.com/ik1xpv/ExtIO_sddc/actions/runs/791098624 named Split the current pipeline into stages CMake #203

howard0su commented 3 years ago

I found the bug and pushed the fix.

On Thu, Apr 29, 2021 at 12:58 AM Oscar Steila @.***> wrote:

I used the Actions compiled release dll https://github.com/ik1xpv/ExtIO_sddc/actions/runs/791098624 named Split the current pipeline into stages CMake #203

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ik1xpv/ExtIO_sddc/pull/199#issuecomment-828618519, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAF3GRF5NZQ65SOZPITKEVLTLA5DPANCNFSM43VFKIOA .

-- -Howard

ik1xpv commented 3 years ago

I fear the bug is partially solved. I'm not able to replicate the solution. I run the Split the current pipeline into stages CMake #204 justarun5 There is still background level difference (very low level )

howard0su commented 3 years ago

I think I missed one line in the previous change. Can you try again?

On Thu, Apr 29, 2021 at 3:17 PM Oscar Steila @.***> wrote:

I fear the bug is partially solved. I'm not able to replicate the solution. I run the Split the current pipeline into stages CMake #204 https://github.com/ik1xpv/ExtIO_sddc/actions/runs/794539799 [image: justarun5] https://user-images.githubusercontent.com/9883800/116514328-29520280-a8cb-11eb-8c8c-62e3c5d412e8.jpg There is still background level difference (very low level )

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ik1xpv/ExtIO_sddc/pull/199#issuecomment-828997374, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAF3GRCWVDGLC6ELZO2BHCLTLEBXPANCNFSM43VFKIOA .

-- -Howard

ik1xpv commented 3 years ago

You got it! I like it :-)) The CMake #205 shows the same background noise of CMake #194. Thanks !