search

ika-rwth-aachen / etsi_its_messages

ROS / ROS 2 Support for ETSI ITS Messages for V2X Communication
MIT License
43 stars 8 forks source link

chore: Update codegen-rust's compiler #31

Closed v0-e closed 2 months ago

v0-e commented 3 months ago

Updates codegen-rust's compiler depedency and related backend code from v0.1.4 to v0.3.0+ (v0.3.0 and some additional commits). Mainly changes related to rasn-compiler's updated API (revamped Backend trait) and other small enhancements. No change in the output of the generated .msgs/conversion headers for current messages.

lreiher commented 3 months ago

Would you mind changing 

on: push

to

on:
  push:
    branches:
      - main
  pull_request:
    branches:
      - main

in codegen.yml, docker-ros.yml and doc.yml?

Currently, CI is inactive for external PRs and we definitely need to change that to verify changes.

lreiher commented 2 months ago

Unfortunately the CI actions are failing cause you cannot push to the container registry, but that is part of the pipeline. I was hoping that I could re-trigger and the actions would inherit my permissions, but apparently that is not the case.

github.actor: The username of the user that triggered the initial workflow run. If the workflow run is a re-run, this value may differ from github.triggering_actor. Any workflow re-runs will use the privileges of github.actor, even if the actor initiating the re-run (github.triggering_actor) has different privileges. source

I am now trying to add you as a collaborator and enable registry push access that way.

jpbusch commented 2 months ago

Hi @v0-e! In the meantime, we have redesigned our CI for external PRs (see https://github.com/ika-rwth-aachen/etsi_its_messages/pull/32). Please undo your changes in the files .github/workflows/codegen.yml, .github/workflows/doc.yml and .github/workflows/docker-ros.yml and merge the current main into your fork. Then the permission issues should be fixed.