vitkabele commented 1 year ago

Add necessary characteristics to enable implementation of Adaptive Lightning. Also provide a demo light bulb implementation to demonstrate the basic usage of the newly added characteristics.

This PR closes #284

codecov[bot] commented 1 year ago

Codecov Report

Merging #428 (f38e6a9) into dev (9a54ecf) will decrease coverage by 0.09%. The diff coverage is 88.46%.

@@            Coverage Diff             @@
##              dev     #428      +/-   ##
==========================================
- Coverage   91.72%   91.63%   -0.10%     
==========================================
  Files          20       20              
  Lines        2128     2140      +12     
  Branches      262      264       +2     
==========================================
+ Hits         1952     1961       +9     
- Misses        134      136       +2     
- Partials       42       43       +1

Impacted Files	Coverage Δ
pyhap/accessory_driver.py	`91.66% <25.00%> (-0.68%)`	:arrow_down:
pyhap/accessory.py	`96.68% <100.00%> (+0.04%)`	:arrow_up:
pyhap/camera.py	`77.21% <100.00%> (ø)`
pyhap/characteristic.py	`100.00% <100.00%> (ø)`
pyhap/iid_manager.py	`100.00% <100.00%> (ø)`
pyhap/service.py	`100.00% <100.00%> (ø)`
pyhap/util.py	`100.00% <100.00%> (ø)`

niorko commented 1 year ago

When it will be integrated into HA? :) I am looking forward to it. Thanks for the work.

vitkabele commented 1 year ago

When it will be integrated into HA? :) I am looking forward to it. Thanks for the work.

Not sure about that. I'm currently trying to figure out how exactly the integration should look. Please see related discussion at HA forum. I'll be happy for any suggestion.

Harshdeep2611 commented 3 months ago

So I have tried to add this characteristics in the custome component and then expose to apple home but adaptive light feature is not there in my light controller in apple home

ikalchev / HAP-python

Add necessary support for Adaptive Lightning #428

Codecov Report