Closed bdraco closed 11 months ago
Merging #464 (6d5b36a) into dev (07df76b) will increase coverage by
0.13%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## dev #464 +/- ##
==========================================
+ Coverage 92.48% 92.62% +0.13%
==========================================
Files 20 20
Lines 2223 2263 +40
Branches 274 279 +5
==========================================
+ Hits 2056 2096 +40
Misses 123 123
Partials 44 44
Files | Coverage Δ | |
---|---|---|
pyhap/accessory.py | 97.33% <100.00%> (ø) |
|
pyhap/accessory_driver.py | 91.98% <100.00%> (ø) |
|
pyhap/characteristic.py | 100.00% <100.00%> (ø) |
|
pyhap/service.py | 100.00% <100.00%> (ø) |
Leaving as draft until parent merges
We have a bug here, we need the hash without the value for the c#
Fixing conflicts...
Retesting
All good
Needs https://github.com/ikalchev/HAP-python/pull/463 merged firstThe hash of accessories would include the value which meant that we would increment the
c#
very frequently which could drain battery and force iCloud to sync over and over. The hash should only include the actual config and not the value. The net result is everything could appear unavailable since the iCloud sync would never finish for some users and the constantget_accessories
could overload the system.HA just added support for reloading accessories which will generate a lot more get requests since the
c#
value is going to change more frequently.to_HAP
is now cached to handle this.