Late-import base36 and QR code libraries; remove SUPPORT_QR_CODE flag

ikalchev / HAP-python

A python implementation of the HomeKit Accessory Protocol (HAP)

Other

619 stars 118 forks source link

Closed akx closed 6 months ago

akx commented 10 months ago

Some tests run locally for home-assistant/core would fail with a cryptic "base36 is not defined" error if that library was not installed.

This PR:

makes that error message cleaner – it's now a RuntimeError that has the import error as a reason
makes pyhap not import base36 or QRCode at all until they are needed
- in doing that removes the SUPPORT_QR_CODE flag; based on GitHub Code Search there are no external users for that flag that I can see.

akx commented 6 months ago

Ping @ikalchev :)

ikalchev commented 6 months ago

Sorry for the huge delay on that!