ikalnytskyi / gnome-shell-extension-icon-hider

Icon Hider is a gnome-shell extension for managing status area items.
Other
31 stars 11 forks source link

Gnome 3.12 Support #17

Closed 183amir closed 10 years ago

183amir commented 10 years ago

Could you please add support for Gnome 3.12?

ikalnytskyi commented 10 years ago

Hello @183amir. Thanks for using my extension. Unfortunately, I don't have GNOME 3.12 on my system, so I can't help you right now. But I'll try to do it in some virtual machine.

BTW, have you try to change shell-version value in metadata.json?

183amir commented 10 years ago

Hello Igor,

It loads and shows up but does not work always. For example I tried to hide the universal access icon and it disappeared after a shell restart. But I cannot hide some icons. Here is a list of icons that are possible to hide them: activities, appMenu, dateMenu, a11y, keyboard, aggregateMenu, weather These icons however cannot be hidden: Caffeine, workrave-applet, gpaste, legacy sys icons in the panel using top icons extension,appindicators such as appindicator-chrome_app_indicator_1

Also, changing the settings from the settings dialog changes nothing. One more thing, hiding and showing icons requires a shell restart.

183amir commented 10 years ago

To give more info: I am getting this error:

Automatically detected errors:

TypeError: this._traymanager is undefined

Version information:

Shell version: 3.12.2
Extension version: 11
ikalnytskyi commented 10 years ago

Ok, thank you. :) I'll try to fix it on Monday, using Ubuntu 14.04 + GNOME 3.12.

ikalnytskyi commented 10 years ago

Hi @183amir! I've just commited a fix. Could you please try version from the repo? If it's ok for you, I'll publish it in the extension directory.

183amir commented 10 years ago

Thank you! It is working great now. :+1: :) The only problem I see now is that I cannot hide legacy sys tray icons (I just want a few of sys tray icons at the top panel) that are in the panel using the TopIcons extension (https://extensions.gnome.org/extension/495/topicons/). However, I think this was also the behavior in Gnome shell 3.10. Hence, I should just probably file this in another issue here or if you think this is not possible, I can request this behavior in TopIcons extension.