search

ikalnytskyi / gnome-shell-extension-icon-hider

Icon Hider is a gnome-shell extension for managing status area items.
Other
31 stars 11 forks source link

Gjs fix #36

Closed theychx closed 6 years ago

theychx commented 6 years ago

fixes #35

@brunelli Can you give this a spin, just to be on the safe side?

brunelli commented 6 years ago

Why is gnome-shell < 3.30 support being dropped? I think it should still work with gjs < 1.53.90, no?

As for the changes in fb46f029b98ea536f8c0814c627ca5a30c42dbc7, it works as expected in gnome-shell 3.30 + gjs 1.54.1!

theychx commented 6 years ago

I think it should still work with gjs < 1.53.90, no?

I'm not much of an gjs/js expert, honestly, so I am not going to assume this (unless you are 100% sure). And besides, the old version of the extension will still be available from extensions.gnome.org to <3.30 users.

theychx commented 6 years ago

It works with 1.52.3 obviously, but I have no way of knowing with older versions.

brunelli commented 6 years ago

It works with 1.52.3

Then we are fine. The related change was introduced with gjs upgrading SpiderMonkey to version 60. The last SpiderMonkey upgrade before that was with gjs 1.49.4, released in July/17.

the old version will still be available from extensions.gnome.org to <3.30 users

But it will keep them from further updates.

theychx commented 6 years ago

@brunelli Thank you for your help!