search

ikalvet / heme_binder_diffusion

69 stars 13 forks source link

Update pipeline.ipynb #3

Closed cn-lugen closed 3 months ago

cn-lugen commented 3 months ago

"Thank you for your hard work! I noticed a very small error and made a correction. In the window named "Analyzing AlphaFold2 predictions," the line submit_script_analysis = ... should be changed to submit_script to maintain consistency with the submission command below. Alternatively, you can modify submit_script in the submission command to submit_script_analysis. To keep consistency with other windows, I modified submit_script_analysis to submit_script, and after testing, this step ran successfully."

ikalvet commented 3 months ago

Thank you for noticing this embarrassing bug! It looks like in your fix the variable names are now swapped around the other way. You defined submit_script=, and then in the function provide submit_script_analysis. I also found I had introduced the same inconsistency into the "Analyzing diffusion outputs" section. I'll fix these two issues, along with another issue you reported in the main branch without merging this pull request.