search

ikappas / vscode-composer

PHP Composer for Visual Studio Code
MIT License
24 stars 7 forks source link

Added the ability to set the project root folder #1

Closed VernonGrant closed 6 years ago

VernonGrant commented 8 years ago

Hello,

First of all I would just like to say awesome plugin and it's very well constructed and coded. :+1: I started using your plugin this morning and couldn't find a way to set the location of the folder holding composer.json file or in other words set or change the root location of my Project.Sometimes my composer.json file is not located in the root of my workspace.

So I went ahead and tried my best to implement this feature. I added the option for the user to set the project root/folder containing the composer.json file. This setting should be defined in the workspace settings.

{ "composer.projectRoot": ".\\applications\\application_root\\" }

Let me know what you think? and if there's anything you feel should be changed please let me know.

Thanks, Vernon

ikappas commented 8 years ago

Hi Vernon, and thank you for taking the time to improve this.

I'll have a look and let you know.

VernonGrant commented 8 years ago

Ok thanks and no pressure.

ikappas commented 6 years ago

@VernonGrant Thank you again for this MR. This has been implemented in the latest develop branch as composer.workingPath setting.