search

ikappas / vscode-phpcs

PHP CodeSniffer for Visual Studio Code
MIT License
128 stars 56 forks source link

[Discussion] [Live Share] Restricting language services to local files #109

Open lostintangent opened 6 years ago

lostintangent commented 6 years ago

In preparation for Visual Studio Live Share adding support for "guests" to receive remote language services for PHP, this PR simply updates the current DocumentSelector to be limited to local files. This way, when someone has the PHPCS extension installed, and joins a Live Share session (where files use the vsls: scheme), their diagnostics will be entirely derived from the remote/host side, which provides a more accurate and project-wide experience (guests in Live Share don't have local file access to the project they're collaborating with).

lostintangent commented 6 years ago

@ikappas Any thoughts on this proposal? It's fully backwards compatible with the current extension, and so shouldn't be a risky change.