ikappas / vscode-phpcs

PHP CodeSniffer for Visual Studio Code
MIT License
128 stars 56 forks source link

PSR12 Support? #156

Closed AdamMarton closed 5 years ago

AdamMarton commented 5 years ago

Hi There,

Would you mind adding PSR12 support?

Currently I'm getting the following error when setting standard to PSR12:

phpcs: The "PSR12" coding standard is not installed. Please review your configuration an try again.

Cheers,

josias-r commented 5 years ago

Do you have the latest version of phpcs installed (currently v3.5.0)? It's working with my installation.

vscode-phpcs is only a wrapper for phpcs itself.

AdamMarton commented 5 years ago

Hi @josias-r ,

Interestingly enough, I have. Running it in command line works just fine. Do you have any idea what could be the issue?

AdamMarton commented 5 years ago

Just to be sure I've set PSR12 as default standard, still no luck.

AdamMarton commented 5 years ago

Setting PHPCS:Executable Path in settings resolves the issue.

josias-r commented 5 years ago

Setting the composerjson path should also work.