Ctrl + H to share isn't working after opening the three dots menu and closing it

ikarago / Notepad

A Fluent-style Notepad-application because Microsoft doesn't make it.

MIT License

118 stars 14 forks source link

Ctrl + H to share isn't working after opening the three dots menu and closing it #25

Closed MarcAnt01 closed 5 years ago

prayaas-a commented 5 years ago

This looks like it's a UWP bug based on this SO question. Apparently (according to replies by MSFT people) this bug has been fixed as of late 2018 Insider builds (which means it likely shipped with 1903) but it's unfortunately an SDK level bug that hasn't been hotfixed for older versions of the OS yet.

ikarago commented 5 years ago

Like @prayaas-a said, this seems to be an UWP bug, so I won't fix this as this can only be done by Microsoft fixing this in the CommandBar itself (that is, without me having to spend a lot of time on very hacky fixes, which I rather spend fixing more major bugs in the project).

I will update the SDK once Microsoft releases that for the next big release this year, so by then it should hopefully be fixed for all. ;)

prayaas-a commented 5 years ago

WinUI 3.0 can't come soon enough haha. That'll decouple the UI layer from the Windows SDK entirely, so you'll be able to target 1703 (for example) while still using the controls and bugfixes released in 2019/2020 SDKs via a NuGet package. Once WinUI 3.0 comes out, it might be a good idea to move this project to it.

For now, perhaps we could move to WinUI 2.1 (aka Microsoft.UI.Xaml via NuGet for the UI rather than the SDK's Windows.UI.Xaml). It's the latter currently iirc. It might fix this issue. What do you think @ikarago ?