ikarago / Notepad

A Fluent-style Notepad-application because Microsoft doesn't make it.
MIT License
118 stars 14 forks source link

Useless and ugly point hover preview in exit confirmation dialog #26

Closed MarcAnt01 closed 5 years ago

MarcAnt01 commented 5 years ago

image

prayaas-a commented 5 years ago

From what I understand, @ikarago has enabled "keyboard accelerators" (fancy MS speak for shortcut), so you can press Y or N on the keyboard to select the corresponding action. Since Windows 10 1803, the SDK displays a tooltip with the accelerator by default unless overridden. You're right, it does look ugly and I can think of a few different changes:

ikarago commented 5 years ago

Is this more to your liking? :)

image

MarcAnt01 commented 5 years ago

I don't like Y/N in general, but in this way it looks better👍

prayaas-a commented 5 years ago

Great for discoverability! And what happens when you hover? Did you get to change the tool tip?

ikarago commented 5 years ago

I have been able to hide the tooltips for now, as I'm not sure if it would be better UX if the ToolTip explains the option or just not show up at all (as all needed info is already in sight)

prayaas-a commented 5 years ago

Yeah the tool tip would be redundant I think

ikarago commented 5 years ago

I've redone the wording of the dialog. What do you think @MarcAnt01?

image

MarcAnt01 commented 5 years ago

I like it, good work @ikarago