Add fr-FR - Githubissues

ikarago / Notepad

A Fluent-style Notepad-application because Microsoft doesn't make it.

MIT License

118 stars 14 forks source link

Add fr-FR #37

Closed FJduFou closed 4 years ago

FJduFou commented 4 years ago

I translate after

ikarago commented 4 years ago

Will look into this when I'm home so I can properly merge the different PR's together. :)

Thank you so much so far for the help with translating the app! 😊

ikarago commented 4 years ago

It has been added. Again thank you so much for translating the app! 😊

ikarago commented 4 years ago

@FJduFou Hmmm, seems like the resource file for FR-fr still only contains the English strings.

Do you happen to have a file with the raw translations still with you? If so, can you send them to me, then I'll add them manually. ;)

FJduFou commented 4 years ago

FJduFou commented 4 years ago

I preferred to do it in 2 steps, the 1st was the integration of Language Toolkit (refuse) the 2nd was the translation (in progress)

ikarago commented 4 years ago

All right, feel free to do a PR with all the changes in it when it's ready. :) That way the PR will include all changes you've made (as multiple seperate PR's make it crazy hard for me to see which ones have the most current changes. ;) )

FJduFou commented 4 years ago

I did not know how to put multiple files in one PR

ikarago commented 4 years ago

If you work in your fork you can create commits to your own repo so you can still work incremental. Once you're done, you can click on "New Pull Request" on this repository. GitHub will then automatically select your main branch (you can also select a different one) that you want to merge with my repo.

If you do that the Pull Request will automatically include all changes you've made and synced with your fork on GutHub. 😊

FJduFou commented 4 years ago

oki, thx 😅