ikaros-project / ikaros

An open infrastructure for system level brain modeling
GNU Affero General Public License v3.0
22 stars 23 forks source link

SizeList expressions with size_x are not handled correctly #213

Closed christianbalkenius closed 4 weeks ago

christianbalkenius commented 1 month ago

e.g. size = "INPUT.size_x, INPUT_size_y" does not work,.

birgerjohansson commented 1 month ago

Maybe change this line to https://github.com/ikaros-project/ikaros/blob/8a521dbb2d3f476d8f63e03daec7eb4d743bcb07/Source/Kernel/ikaros.cc#L773

if(ends_with(e, ".size") || ends_with(e, ".size_x") || ends_with(e, ".size_y")) // special case: use shape function on input and push each dimension on list