ikarus-project / ikarus-examples

https://ikarus-project.github.io
Other
0 stars 1 forks source link

fix iks003, iks004, and iks007 #23

Closed tarun-mitruka closed 9 months ago

rath3t commented 10 months ago

can this be rebased and merged? I totally forgot about this PR @tarun-mitruka

tarun-mitruka commented 10 months ago

can this be rebased and merged? I totally forgot about this PR @tarun-mitruka

No. There was no open issue yet but I realized a bit later that the analytical solution computation in iks004 only works correctly if Lx=1 and Ly=1. We can discuss and correct this and then merge this branch. I have fixed the PR title now.