search

ikarus-project / ikarus

Ikarus is a C++-based library that uses DUNE modules to solve partial differential equations with the finite element method and more.
https://ikarus-project.github.io/
Other
5 stars 3 forks source link

fe.size() should be replaced with numberOfNodes in all finite elements #204

Closed tarun-mitruka closed 9 months ago

henrij22 commented 9 months ago

While fixing this, we could also adress the constness of this line: https://github.com/ikarus-project/ikarus/blob/7e793d0ae955b4b11ba7d2c98522775495abe703/ikarus/finiteelements/febases/powerbasisfe.hh#L52

I think it should be 

const GridElementEntityType& gridElement() const { return localView_.element(); }

Same here https://github.com/ikarus-project/ikarus/blob/7e793d0ae955b4b11ba7d2c98522775495abe703/ikarus/finiteelements/febases/scalarfe.hh#L42