Closed rath3t closed 7 months ago
@tarun-mitruka Since, your last PR adds a heavy test which takes very long the coverage went done, since it is not tested anymore. Now Coverage only uses cpp_quick
Ctest label. Can you write proper faster tests, i.e. some unit tests? Thanks!
@tarun-mitruka Since, your last PR adds a heavy test which takes very long the coverage went done, since it is not tested anymore. Now Coverage only uses
cpp_quick
Ctest label. Can you write proper faster tests, i.e. some unit tests? Thanks!
Sure. Can you open a new issue for it? Else, it might get lost in the comments. Perhaps after #88, testadaptivestepsizing.cpp
can be moved to cpp_quick
, probably with some refactoring.
Codecov Report
Attention:
84 lines
in your changes are missing coverage. Please review.Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #220 +/- ## ========================================== - Coverage 91.32% 82.42% -8.90% ========================================== Files 45 47 +2 Lines 1879 1855 -24 ========================================== - Hits 1716 1529 -187 - Misses 163 326 +163 ``` | [Flag](https://app.codecov.io/gh/ikarus-project/ikarus/pull/220/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ikarus-project) | Coverage Δ | | |---|---|---| | [tests](https://app.codecov.io/gh/ikarus-project/ikarus/pull/220/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ikarus-project) | `82.42% <69.67%> (-8.90%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ikarus-project#carryforward-flags-in-the-pull-request-comment) to find out more.:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.