search

ikarus-project / ikarus

Ikarus is a C++-based library that uses DUNE modules to solve partial differential equations with the finite element method and more.
https://ikarus-project.github.io/
Other
5 stars 3 forks source link

Refactor class documentation #220

Closed rath3t closed 7 months ago

codecov[bot] commented 8 months ago

Codecov Report

Attention: 84 lines in your changes are missing coverage. Please review.

Comparison is base (1c8e1be) 91.32% compared to head (04337f5) 82.42%. Report is 1 commits behind head on main.

Files Patch % Lines
ikarus/controlroutines/pathfollowing.inl 0.00% 32 Missing :warning:
ikarus/utils/observer/observer.hh 43.33% 17 Missing :warning:
ikarus/controlroutines/pathfollowingfunctions.hh 0.00% 7 Missing :warning:
ikarus/controlroutines/pathfollowing.hh 0.00% 6 Missing :warning:
...olver/newtonraphsonwithscalarsubsidiaryfunction.hh 0.00% 5 Missing :warning:
ikarus/controlroutines/adaptivestepsizing.hh 0.00% 3 Missing :warning:
ikarus/solver/nonlinearsolver/trustregion.hh 89.28% 3 Missing :warning:
ikarus/utils/observer/controllogger.hh 0.00% 3 Missing :warning:
ikarus/finiteelements/ferequirements.hh 86.66% 2 Missing :warning:
ikarus/io/resultfunction.hh 0.00% 2 Missing :warning:
... and 2 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #220 +/- ## ========================================== - Coverage 91.32% 82.42% -8.90% ========================================== Files 45 47 +2 Lines 1879 1855 -24 ========================================== - Hits 1716 1529 -187 - Misses 163 326 +163 ``` | [Flag](https://app.codecov.io/gh/ikarus-project/ikarus/pull/220/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ikarus-project) | Coverage Δ | | |---|---|---| | [tests](https://app.codecov.io/gh/ikarus-project/ikarus/pull/220/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ikarus-project) | `82.42% <69.67%> (-8.90%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ikarus-project#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

rath3t commented 7 months ago

@tarun-mitruka Since, your last PR adds a heavy test which takes very long the coverage went done, since it is not tested anymore. Now Coverage only uses cpp_quick Ctest label. Can you write proper faster tests, i.e. some unit tests? Thanks!

tarun-mitruka commented 7 months ago

@tarun-mitruka Since, your last PR adds a heavy test which takes very long the coverage went done, since it is not tested anymore. Now Coverage only uses cpp_quick Ctest label. Can you write proper faster tests, i.e. some unit tests? Thanks!

Sure. Can you open a new issue for it? Else, it might get lost in the comments. Perhaps after #88, testadaptivestepsizing.cpp can be moved to cpp_quick, probably with some refactoring.