Closed tarun-mitruka closed 7 months ago
Attention: 2 lines
in your changes are missing coverage. Please review.
Comparison is base (
7291d7e
) 92.73% compared to head (2ee5249
) 92.67%.
Files | Patch % | Lines |
---|---|---|
...rus/finiteelements/mechanics/kirchhoffloveshell.hh | 95.45% | 1 Missing :warning: |
...karus/finiteelements/mechanics/nonlinearelastic.hh | 96.29% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks Tarun!
This pull request is mainly focused on refactoring based on #159 and #170. The load functions are moved to a separate class and use generally among different finite elements. It can be further probably generalized such that a user can define something like
and pass it along with the constructor of a finite element, but modifying according to this will modify the constructor of all finite elements and hence its necessity can be discussed and implemented in a separate PR perhaps.
The documentation will be updated along with #124.
!!! UPDATE As per the PR review,
getDisplacementFunction
is refactored separately in #223