search

ikarus-project / ikarus

Ikarus is a C++-based library that uses DUNE modules to solve partial differential equations with the finite element method and more.
https://ikarus-project.github.io/
Other
5 stars 3 forks source link

Refactor load functionalities #221

Closed tarun-mitruka closed 7 months ago

tarun-mitruka commented 8 months ago

This pull request is mainly focused on refactoring based on #159 and #170. The load functions are moved to a separate class and use generally among different finite elements. It can be further probably generalized such that a user can define something like 

LoadFunctions lf({.volumeLoad=volumeLoad, .neumannLoad=neumannLoad, .neumannBoundary=neumannBoundary, .someOtherLoad = LoadDefault})

and pass it along with the constructor of a finite element, but modifying according to this will modify the constructor of all finite elements and hence its necessity can be discussed and implemented in a separate PR perhaps.

The documentation will be updated along with #124.

!!! UPDATE As per the PR review, getDisplacementFunction is refactored separately in #223

codecov[bot] commented 8 months ago

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (7291d7e) 92.73% compared to head (2ee5249) 92.67%.

Files Patch % Lines
...rus/finiteelements/mechanics/kirchhoffloveshell.hh 95.45% 1 Missing :warning:
...karus/finiteelements/mechanics/nonlinearelastic.hh 96.29% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #221 +/- ## ========================================== - Coverage 92.73% 92.67% -0.06% ========================================== Files 50 52 +2 Lines 1982 1967 -15 ========================================== - Hits 1838 1823 -15 Misses 144 144 ``` | [Flag](https://app.codecov.io/gh/ikarus-project/ikarus/pull/221/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ikarus-project) | Coverage Δ | | |---|---|---| | [tests](https://app.codecov.io/gh/ikarus-project/ikarus/pull/221/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ikarus-project) | `92.67% <98.66%> (-0.06%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ikarus-project#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

rath3t commented 7 months ago

Thanks Tarun!