search

ikarus-project / ikarus

Ikarus is a C++-based library that uses DUNE modules to solve partial differential equations with the finite element method and more.
https://ikarus-project.github.io/
Other
6 stars 3 forks source link

Refactor getDisplacementFunction #223

Closed tarun-mitruka closed 10 months ago

tarun-mitruka commented 11 months ago

This PR was split from #221. See #221 for some PR review comments.

!!! UPDATE std::optional version in finite elements has to be removed and the if-else branch in localSolutionBlockVector has to be determined during compile time. This will be addressed in #228

codecov[bot] commented 11 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (2dfc766) 92.87% compared to head (a216aef) 92.73%. Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #223 +/- ## ========================================== - Coverage 92.87% 92.73% -0.15% ========================================== Files 49 50 +1 Lines 2022 1982 -40 ========================================== - Hits 1878 1838 -40 Misses 144 144 ``` | [Flag](https://app.codecov.io/gh/ikarus-project/ikarus/pull/223/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ikarus-project) | Coverage Δ | | |---|---|---| | [tests](https://app.codecov.io/gh/ikarus-project/ikarus/pull/223/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ikarus-project) | `92.73% <100.00%> (-0.15%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ikarus-project#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.