search

ikarus-project / ikarus

Ikarus is a C++-based library that uses DUNE modules to solve partial differential equations with the finite element method and more.
https://ikarus-project.github.io/
Other
5 stars 3 forks source link

add explicit derivatives of KL shell #225

Closed rath3t closed 7 months ago

rath3t commented 7 months ago

Closes #88.

rath3t commented 7 months ago

@tarun-mitruka @henrij22 as an exercise can you give me a code Review. Suggest changes, more comments/doxygen comments or unclear implementations or other suggestions for refactoring.

You can wait till the CI worked

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (8837c21) 82.53% compared to head (dc4ffaf) 92.87%.

:exclamation: Current head dc4ffaf differs from pull request most recent head 0dfe755. Consider uploading reports for the commit 0dfe755 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #225 +/- ## =========================================== + Coverage 82.53% 92.87% +10.33% =========================================== Files 48 49 +1 Lines 1867 2022 +155 =========================================== + Hits 1541 1878 +337 + Misses 326 144 -182 ``` | [Flag](https://app.codecov.io/gh/ikarus-project/ikarus/pull/225/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ikarus-project) | Coverage Δ | | |---|---|---| | [tests](https://app.codecov.io/gh/ikarus-project/ikarus/pull/225/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ikarus-project) | `92.87% <100.00%> (+10.33%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ikarus-project#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.