search

ikarus-project / ikarus

Ikarus is a C++-based library that uses DUNE modules to solve partial differential equations with the finite element method and more.
https://ikarus-project.github.io/
Other
5 stars 3 forks source link

Change clang-format due to discussion #243

Closed rath3t closed 7 months ago

codecov[bot] commented 7 months ago

Codecov Report

Attention: 140 lines in your changes are missing coverage. Please review.

Comparison is base (7ee00a0) 92.73% compared to head (a7c7561) 91.76%.

Files Patch % Lines
ikarus/solver/nonlinearsolver/trustregion.hh 76.62% 54 Missing :warning:
ikarus/utils/functionsanitychecks.hh 79.26% 17 Missing :warning:
ikarus/io/resultfunction.hh 36.36% 14 Missing :warning:
ikarus/finiteelements/ferequirements.hh 81.81% 8 Missing :warning:
ikarus/linearalgebra/truncatedconjugategradient.hh 90.36% 8 Missing :warning:
...iteelements/mechanics/materials/vanishingstress.hh 88.88% 7 Missing :warning:
...finiteelements/mechanics/enhancedassumedstrains.hh 98.08% 5 Missing :warning:
ikarus/utils/makeenum.hh 0.00% 5 Missing :warning:
ikarus/assembler/simpleassemblers.inl 93.93% 4 Missing :warning:
ikarus/finiteelements/mechanics/loads/traction.hh 91.11% 4 Missing :warning:
... and 12 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #243 +/- ## ========================================== - Coverage 92.73% 91.76% -0.97% ========================================== Files 53 53 Lines 1982 2029 +47 ========================================== + Hits 1838 1862 +24 - Misses 144 167 +23 ``` | [Flag](https://app.codecov.io/gh/ikarus-project/ikarus/pull/243/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ikarus-project) | Coverage Δ | | |---|---|---| | [tests](https://app.codecov.io/gh/ikarus-project/ikarus/pull/243/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ikarus-project) | `91.76% <92.30%> (-0.97%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ikarus-project#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

tarun-mitruka commented 7 months ago

Looks good from my side. We have to talk about fixing the member variable naming with the trailing _. Maybe someone can go through all files and fix it manually? Or we say: Everytime someone touches upon a file they should also check member variable

@henrij22 I think this change, along with using \ instead of & for doxygen comments and further changes will be now done in #234 separately., while the focus here was only clang-format related changes. Am I right @rath3t ?

rath3t commented 7 months ago

This PR is only the clang-format. In another one I would try to fix the member variables stuff.