Closed tarun-mitruka closed 7 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
2d37f50
) 91.77% compared to head (ca46d5e
) 91.77%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Again you mixed the refactoring of the traits and the usage of PowerBasisFE Basis template. This should be again avoided next time.
Again you mixed the refactoring of the traits and the usage of PowerBasisFE Basis template. This should be again avoided next time.
Yes. I mixed it as FETraits
takes in the GlobalBasis
as template parameter for the finite elements and PowerBasisFE
only directly had the FlatBasis.
Since I wanted to generalize this, I had to do it in the same PR to make it work. Could there have been a better solution? @rath3t
Ah i missed that! Then its ok to do it like that!
This PR focuses on merging
FETraits
andTraitsFromFE
to avoid duplication of code. It also now handlesbasis.flat()
inPowerBasisFE
andScalarFieldFE
such that this need not be repeated in the constructor of every finite element.