search

ikarus-project / ikarus

Ikarus is a C++-based library that uses DUNE modules to solve partial differential equations with the finite element method and more.
https://ikarus-project.github.io/
Other
6 stars 3 forks source link

Revisit ResultEvaluators #251

Closed henrij22 closed 9 months ago

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (269b7cf) 93.16% compared to head (1f5533d) 91.38%.

:exclamation: Current head 1f5533d differs from pull request most recent head 02e384e. Consider uploading reports for the commit 02e384e to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #251 +/- ## ========================================== - Coverage 93.16% 91.38% -1.78% ========================================== Files 57 57 Lines 2048 1950 -98 ========================================== - Hits 1908 1782 -126 - Misses 140 168 +28 ``` | [Flag](https://app.codecov.io/gh/ikarus-project/ikarus/pull/251/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ikarus-project) | Coverage Δ | | |---|---|---| | [tests](https://app.codecov.io/gh/ikarus-project/ikarus/pull/251/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ikarus-project) | `91.38% <100.00%> (-1.78%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ikarus-project#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

henrij22 commented 9 months ago

I refactored according to your comments: we have now the following format: 

// If no UserFunction is provided
auto resultFunction = Ikarus::makeResultFunction<resType>(&fes, feRequirements);

// With UserFunction
auto resultFunction = Ikarus::makeResultFunction<resType, ResultEvaluator>(&fes, feRequirements);
rath3t commented 9 months ago

Thanks Henri!