fix release workflows - Githubissues

ikarus-project / ikarus

Ikarus is a C++-based library that uses DUNE modules to solve partial differential equations with the finite element method and more.

https://ikarus-project.github.io/

Other

4 stars 2 forks source link

fix release workflows #262

Open tarun-mitruka opened 4 months ago

tarun-mitruka commented 4 months ago

[ ] .git folder show not be inside the asset files
[ ] All file and folder names should end with vx.xx instead of x.xx, for example, ikarus-examples-v0.4.zip is to be used instead of ikarus-examples-0.4.zip as the file name and the folder inside should also be named as ikarus-examples-v0.4

rath3t commented 4 months ago

We discussed we want to mimic the Github default as in the releases https://github.com/ikarus-project/ikarus/releases/tag/v0.4. Here the ikarus source folder is without the v. Now you refactored it the other way around. Is this also the case for the Environment PR?

tarun-mitruka commented 4 months ago

We discussed we want to mimic the Github default as in the releases https://github.com/ikarus-project/ikarus/releases/tag/v0.4. Here the ikarus source folder is without the v. Now you refactored it the other way around. Is this also the case for the Environment PR?

Ah sorry, I thought we discussed that it looks better with the v and only the source code for ikarus was missing it. I have refactored it such that now it is with the v everywhere, both in DaRUS repository for v0.4 and in https://github.com/ikarus-project/Environments/pull/1. I did the refactoring in DaRUS manually. Should anything be modified in the asset files here as well?

rath3t commented 4 months ago

We can also decide to add/keep the v everywhere. I agree that it looks better

rath3t commented 4 months ago

I think the issue her is fine then. I will give you a review for the env in the afternoon