ikarus-project / ikarus

Ikarus is a C++-based library that uses DUNE modules to solve partial differential equations with the finite element method and more.

https://ikarus-project.github.io/

Other

6 stars 3 forks source link

Update python Interface for `DirichletValues` #277

Closed henrij22 closed 2 months ago

henrij22 commented 7 months ago

The python interface for dirichlet values as far as I can see doesn't allow to fix DOFs, that are not part of the boundary . Normally I would have assumed that https://github.com/ikarus-project/ikarus/blob/081099d302ec829f20dac1f4f0f0a9cee0705b29/ikarus/python/dirichletvalues/dirichletvalues.hh#L108 could fix other values, but this forwards to

 self.fixBoundaryDOFs(f);

This is in contrast to the interface that the C++ class has, where https://github.com/ikarus-project/ikarus/blob/081099d302ec829f20dac1f4f0f0a9cee0705b29/ikarus/utils/dirichletvalues.hh#L95 does somthing else.

[x] Change interface to be more flexible
[x] Check if python bindings for subspacebasis are working
[x] Write a dirichletvalues test

Update 01.07.24

Most of this is fixed with #305 , only fixing non-boundary-dofs is not yet adressed properly

henrij22 commented 2 months ago

This is obsolete with #305