ikarus-project / ikarus

Ikarus is a C++-based library that uses DUNE modules to solve partial differential equations with the finite element method and more.
https://ikarus-project.github.io/
Other
4 stars 2 forks source link

Homogenize Python Bindings for DirichletValues + Support for fixing Subspace Basis #305

Open henrij22 opened 3 weeks ago

henrij22 commented 3 weeks ago

This also relates to issue #277

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.63%. Comparing base (1f6d41c) to head (390f2e1).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #305 +/- ## ========================================== + Coverage 91.24% 91.63% +0.39% ========================================== Files 63 62 -1 Lines 2055 2260 +205 ========================================== + Hits 1875 2071 +196 - Misses 180 189 +9 ``` | [Flag](https://app.codecov.io/gh/ikarus-project/ikarus/pull/305/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ikarus-project) | Coverage Δ | | |---|---|---| | [tests](https://app.codecov.io/gh/ikarus-project/ikarus/pull/305/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ikarus-project) | `91.63% <100.00%> (+0.39%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ikarus-project#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

henrij22 commented 2 days ago

So this should be more or less ready. I also added the missing bindings for size to the flatassemblers

henrij22 commented 9 hours ago

@tarun-mitruka This might break some of your existing code, as the function

  void fixIthDof(const MultiIndex i);

is replaced with

  void setSingleDOF(const MultiIndex i, bool flag);
tarun-mitruka commented 8 hours ago

@tarun-mitruka This might break some of your existing code, as the function

  void fixIthDof(const MultiIndex i);

is replaced with

  void setSingleDOF(const MultiIndex i, bool flag);

Okay. Thank you for mentioning. You can also add such breaking changes in CHANGELOG.md. I will check out the reasons for this change while doing the review.