Closed henrij22 closed 2 months ago
Python linting and formatting should be harmonized. For example the following line was not formatted correctly (spaces are missing) and the CI didn't catch this https://github.com/ikarus-project/ikarus/blob/fa0c8068a8de02ccbc9d3bdf2587690f60049d0a/ikarus/python/test/linearelastictest.py#L72 Also this Codacity Tool doesn't seem to be predictable. I have reformatted some code, and it found new issues therein, but I only changed format.
I would suggest using something like Ruff for formatting and linting, maybe with a custom set of rules (https://github.com/astral-sh/ruff) This can also be done via GH Action
Backlog!
Python linting and formatting should be harmonized. For example the following line was not formatted correctly (spaces are missing) and the CI didn't catch this https://github.com/ikarus-project/ikarus/blob/fa0c8068a8de02ccbc9d3bdf2587690f60049d0a/ikarus/python/test/linearelastictest.py#L72 Also this Codacity Tool doesn't seem to be predictable. I have reformatted some code, and it found new issues therein, but I only changed format.
I would suggest using something like Ruff for formatting and linting, maybe with a custom set of rules (https://github.com/astral-sh/ruff) This can also be done via GH Action