search

ikarus-project / ikarus

Ikarus is a C++-based library that uses DUNE modules to solve partial differential equations with the finite element method and more.
https://ikarus-project.github.io/
Other
6 stars 3 forks source link

Hotfix: Size property of assembler & assemblermanipulator #311

Closed henrij22 closed 4 months ago

henrij22 commented 4 months ago

During merging my PR I noticed that the size property for assemblermanipulator was not working, so this is a hotfix for that

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.38%. Comparing base (29a1a7c) to head (0e40bcb).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #311 +/- ## ======================================= Coverage 91.38% 91.38% ======================================= Files 64 64 Lines 2263 2263 ======================================= Hits 2068 2068 Misses 195 195 ``` | [Flag](https://app.codecov.io/gh/ikarus-project/ikarus/pull/311/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ikarus-project) | Coverage Δ | | |---|---|---| | [tests](https://app.codecov.io/gh/ikarus-project/ikarus/pull/311/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ikarus-project) | `91.38% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ikarus-project#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

rath3t commented 4 months ago

What is the problem here? Can I help maybe Anika needs this fix i assume.

rath3t commented 4 months ago

Thanks!